From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzZa6-0007LH-QB for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:57:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzZa6-0007Kk-8p for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:57:54 -0400 Received: from [199.232.76.173] (port=41110 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzZa6-0007Ka-2s for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:57:54 -0400 Received: from fg-out-1718.google.com ([72.14.220.158]:48031) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzZa5-0003Lj-IZ for qemu-devel@nongnu.org; Thu, 30 Apr 2009 12:57:53 -0400 Received: by fg-out-1718.google.com with SMTP id l27so1220336fgb.8 for ; Thu, 30 Apr 2009 09:57:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49F9D2B3.60707@us.ibm.com> References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <200904291137.57852.paul@codesourcery.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> Date: Thu, 30 Apr 2009 19:57:51 +0300 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Avi Kivity , Paul Brook On 4/30/09, Anthony Liguori wrote: > Paul Brook wrote: > > > > > > Sure, you can short-ciruit the case where you have a pair of devices, > > > but then you need to revoke posted receive descriptors. > > > > > > > > > > Isn't the same true with a point-point API? When you add a third device to > the vlan you're going to have to break the tap-guest link, and insert a > proxy in the middle. > > > > > > The difference is that if you assume vlan, then you have to handle > renegotiation of features which is not actually possible. With virtio-net, > once you enable guest GSO, you cannot disable it. You would have to > implement GSO emulation within QEMU if you wanted to disable it on the tap > device. > > If you don't assume vlan, then you can choose the least amount of features > when in a vlan. Then you never have to deal with this problem. > > And yes, that means that if you wanted to support the existing syntax, you > would need a flag like: > > -net tap,i-will-never-add-more-devices-to-this-vlan=on > -net nic,model=virtio > -net pointopoint,tap,nic,model=virtio ?