From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzbSL-00037S-NX for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:58:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzbSL-00037E-9t for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:58:01 -0400 Received: from [199.232.76.173] (port=42207 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzbSL-00037B-5k for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:58:01 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:3613) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzbSK-0004gR-N0 for qemu-devel@nongnu.org; Thu, 30 Apr 2009 14:58:00 -0400 Received: by fg-out-1718.google.com with SMTP id e21so656605fga.8 for ; Thu, 30 Apr 2009 11:57:59 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <49F9EECE.8020301@us.ibm.com> References: <1239812969-8320-2-git-send-email-markmc@redhat.com> <49F9AB7C.7020803@redhat.com> <200904301702.32282.paul@codesourcery.com> <49F9D2B3.60707@us.ibm.com> <49F9DBCC.3030906@us.ibm.com> <49F9E3CB.4000604@web.de> <49F9E71F.50009@us.ibm.com> <49F9EECE.8020301@us.ibm.com> Date: Thu, 30 Apr 2009 21:57:59 +0300 Message-ID: From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , Marcelo Tosatti , Markus Armbruster , qemu-devel@nongnu.org, Jan Kiszka , Avi Kivity , Paul Brook On 4/30/09, Anthony Liguori wrote: > Blue Swirl wrote: > > > On 4/30/09, Anthony Liguori wrote: > > > > > > > Jan Kiszka wrote: > > > > > > > > > > > > > That would only allow one such pair per VM. > > > > > > > > > > > > > > > > > > > id basically becomes another type of vlan id. To have multiple nics, > you > > > do: > > > > > > -net tap,vlan=off,id=1234 -net > > > nic,model=virtio,vlan=off,id=1234 > > > -net tap,vlan=off,id=4321 -net > > > nic,model=virtio,vlan=off,id=4321 > > > > > > > > > > I think "off" and "id" are not descriptive enough, how about: > > -net tap,vlan=pointopoint,ptop_id=4321 -net > > nic,model=virtio,vlan=pointopoint,ptop_id=4321 > > > > > > or vlan=none? p2p doesn't make very much sense to me personally. That's good too. > I agree "id" may be too generic. Maybe devid or device_id? That may be confused with for example PCI ID. pair_id? > > > I think you're suggesting the same thing as me, except you are saying > make > > > vlan=off implicit, and use vlan=XXX instead of id=XXX. > > > > > > We can still make vlan=off implicit, and default id=0, so that -net tap > net > > > nic,model=virtio does the right thing. However, if a user explicitly > says > > > -net tap,vlan=1 -net nic,model=virtio,vlan=1, it behaves like it used > to. > > > > > > > > > > Nice, though if there are two vlans, one specified without explicit ID > > and the other with ID=1, the performance will be different. > > > > > > If a user mixes vlans and p2p links, then yeah, performance is going to be > different. I'd like to eventually make vlan=none the default to be > perfectly honest. I don't think many people depend on implicit vlan=0 so I > don't think we'll really break anyone. No, and also different performance won't matter.