From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzwWN-0007m3-GK for qemu-devel@nongnu.org; Fri, 01 May 2009 13:27:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzwWI-0007kW-Ko for qemu-devel@nongnu.org; Fri, 01 May 2009 13:27:34 -0400 Received: from [199.232.76.173] (port=59465 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzwWI-0007kR-At for qemu-devel@nongnu.org; Fri, 01 May 2009 13:27:30 -0400 Received: from mail-fx0-f219.google.com ([209.85.220.219]:65184) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzwWH-0002uy-RS for qemu-devel@nongnu.org; Fri, 01 May 2009 13:27:30 -0400 Received: by fxm19 with SMTP id 19so2184629fxm.34 for ; Fri, 01 May 2009 10:27:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 1 May 2009 20:27:28 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/4] Confine use of global rtc_state to PC CMOS functions From: Blue Swirl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 4/30/09, Markus Armbruster wrote: > Pass the state as argument to cmos_init() and cmos_init_hd(). > cmos_init() still needs to save it in rtc_state for use by > cmos_set_s3_resume(). pc.c could pass acpi an opaque handle (former rtc_state) at init or acpi could export a function to set the handle, called by pc.c. Then cmos_set_s3_resume could take a state parameter.