From: Blue Swirl <blauwirbel@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] Remove global floppy_controller
Date: Fri, 1 May 2009 20:31:45 +0300 [thread overview]
Message-ID: <f43fc5580905011031h41dbf851m5e22ff425b8d07e@mail.gmail.com> (raw)
In-Reply-To: <9b44b171aa0919e1df03c7e7bcbbcf09168e0955.1241106809.git.armbru@redhat.com>
On 4/30/09, Markus Armbruster <armbru@redhat.com> wrote:
> Change cmos_init() to take the floppy drive types as arguments instead
> of getting them through global floppy_controller.
>
> Change fdctrl_get_drive_type() to take a BlockDriverState argument.
> Factor fd_format() out of fd_revalidate() to make that possible.
>
> Use it to compute the new arguments for cmos_init().
Looks OK.
next prev parent reply other threads:[~2009-05-01 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1241106809.git.armbru@redhat.com>
2009-04-30 16:03 ` [Qemu-devel] [PATCH 1/4] Confine use of global rtc_state to PC CMOS functions Markus Armbruster
2009-05-01 17:27 ` Blue Swirl
2009-05-04 13:54 ` Markus Armbruster
2009-05-05 16:22 ` Blue Swirl
2009-05-19 6:56 ` Markus Armbruster
2009-05-19 16:51 ` Blue Swirl
2009-05-19 16:57 ` Avi Kivity
2009-04-30 16:03 ` [Qemu-devel] [PATCH 2/4] Remove global floppy_controller Markus Armbruster
2009-05-01 17:31 ` Blue Swirl [this message]
2009-04-30 16:03 ` [Qemu-devel] [PATCH 3/4] Give parse_macaddr() external linkage Markus Armbruster
2009-04-30 16:03 ` [Qemu-devel] [PATCH 4/4] Machine description as data Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580905011031h41dbf851m5e22ff425b8d07e@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).