From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzwaW-0000i5-9p
	for qemu-devel@nongnu.org; Fri, 01 May 2009 13:31:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzwaR-0000ef-2C
	for qemu-devel@nongnu.org; Fri, 01 May 2009 13:31:51 -0400
Received: from [199.232.76.173] (port=40817 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzwaQ-0000eV-L1
	for qemu-devel@nongnu.org; Fri, 01 May 2009 13:31:46 -0400
Received: from mail-fx0-f219.google.com ([209.85.220.219]:64731)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1LzwaQ-0003RY-7A
	for qemu-devel@nongnu.org; Fri, 01 May 2009 13:31:46 -0400
Received: by fxm19 with SMTP id 19so2186057fxm.34
	for <qemu-devel@nongnu.org>; Fri, 01 May 2009 10:31:45 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <9b44b171aa0919e1df03c7e7bcbbcf09168e0955.1241106809.git.armbru@redhat.com>
References: <cover.1241106809.git.armbru@redhat.com>
	<9b44b171aa0919e1df03c7e7bcbbcf09168e0955.1241106809.git.armbru@redhat.com>
Date: Fri, 1 May 2009 20:31:45 +0300
Message-ID: <f43fc5580905011031h41dbf851m5e22ff425b8d07e@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] Remove global floppy_controller
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 4/30/09, Markus Armbruster <armbru@redhat.com> wrote:
> Change cmos_init() to take the floppy drive types as arguments instead
>  of getting them through global floppy_controller.
>
>  Change fdctrl_get_drive_type() to take a BlockDriverState argument.
>  Factor fd_format() out of fd_revalidate() to make that possible.
>
>  Use it to compute the new arguments for cmos_init().

Looks OK.