From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M1mpr-0002na-Sv
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:31:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M1mpp-0002mv-Uo
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:31:18 -0400
Received: from [199.232.76.173] (port=39403 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M1mpp-0002ms-SG
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:31:17 -0400
Received: from fg-out-1718.google.com ([72.14.220.152]:20655)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M1mpp-0000kS-3e
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:31:17 -0400
Received: by fg-out-1718.google.com with SMTP id l27so1289507fgb.8
	for <qemu-devel@nongnu.org>; Wed, 06 May 2009 12:31:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1241621382-21577-4-git-send-email-glommer@redhat.com>
References: <1241621382-21577-1-git-send-email-glommer@redhat.com>
	<1241621382-21577-2-git-send-email-glommer@redhat.com>
	<1241621382-21577-3-git-send-email-glommer@redhat.com>
	<1241621382-21577-4-git-send-email-glommer@redhat.com>
Date: Wed, 6 May 2009 22:31:15 +0300
Message-ID: <f43fc5580905061231p55f28a25u2cc30d812532e027@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] move halted state setting to inside of
	cpu_x86_init
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 5/6/09, Glauber Costa <glommer@redhat.com> wrote:
> cpus other than the first one starting at the halted state
>  is a safe assumption to anyone. Move it to where it belongs.

The code should be conditional to !CONFIG_USER_ONLY.

The same happens with Sparc, so I'd move this to exec.c:cpu_exec_init().