From: Blue Swirl <blauwirbel@gmail.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] move registering of cpu_reset to inside cpu_init
Date: Wed, 6 May 2009 22:36:16 +0300 [thread overview]
Message-ID: <f43fc5580905061236l1adf41eicce52055e95bef5b@mail.gmail.com> (raw)
In-Reply-To: <1241621382-21577-2-git-send-email-glommer@redhat.com>
On 5/6/09, Glauber Costa <glommer@redhat.com> wrote:
> This is not pc specific by any means. So we can be
> moved to inside cpu_x86_init().
>
> This is part of an attempt to only initialize kvm state
> after everything is already properly initialized. If we don't
> do that, we can race against, for example, APIC state if kvm vcpus
> are ran in threads (happens in qemu-kvm.git, soon to happen here too)
I'd move this too to exec.c. Sparc registers two reset functions, the
first one for the main cpu disables halted state, the second one for
non-boot cpus halts them on reset. I wonder why i386 does not do the
same.
next prev parent reply other threads:[~2009-05-06 19:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 14:49 [Qemu-devel] [PATCH 0/4] Simplify cpu initialization Glauber Costa
2009-05-06 14:49 ` [Qemu-devel] [PATCH 1/4] move registering of cpu_reset to inside cpu_init Glauber Costa
2009-05-06 14:49 ` [Qemu-devel] [PATCH 2/4] move CPUID_APIC flag to where it belongs Glauber Costa
2009-05-06 14:49 ` [Qemu-devel] [PATCH 3/4] move halted state setting to inside of cpu_x86_init Glauber Costa
2009-05-06 14:49 ` [Qemu-devel] [PATCH 4/4] move apic functions to a separate apic.h header Glauber Costa
2009-05-06 15:52 ` [Qemu-devel] " Jan Kiszka
2009-05-06 16:08 ` Glauber Costa
2009-05-06 15:45 ` [Qemu-devel] Re: [PATCH 3/4] move halted state setting to inside of cpu_x86_init Jan Kiszka
2009-05-06 19:31 ` [Qemu-devel] " Blue Swirl
2009-05-06 21:42 ` Glauber Costa
2009-05-06 15:40 ` [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs Jan Kiszka
2009-05-06 15:51 ` Glauber Costa
2009-05-06 17:29 ` Stanislav
2009-05-06 17:41 ` Glauber Costa
2009-05-06 17:43 ` Stanislav
2009-05-06 18:17 ` Anthony Liguori
2009-05-06 17:02 ` [Qemu-devel] Re: [PATCH 1/4] move registering of cpu_reset to inside cpu_init Jan Kiszka
2009-05-06 19:36 ` Blue Swirl [this message]
2009-05-06 21:45 ` [Qemu-devel] " Glauber Costa
-- strict thread matches above, loose matches on Subject: below --
2009-05-07 18:50 [Qemu-devel] [PATCH 0/4] Simplify cpu_init Glauber Costa
2009-05-07 18:51 ` [Qemu-devel] [PATCH 1/4] move registering of cpu_reset to inside cpu_init Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580905061236l1adf41eicce52055e95bef5b@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).