From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M1muh-000515-Dm
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:36:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M1mug-00050r-2s
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:36:18 -0400
Received: from [199.232.76.173] (port=37705 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M1muf-00050o-UM
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:36:17 -0400
Received: from fg-out-1718.google.com ([72.14.220.156]:32037)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M1muf-00024b-Gc
	for qemu-devel@nongnu.org; Wed, 06 May 2009 15:36:17 -0400
Received: by fg-out-1718.google.com with SMTP id e21so119328fga.8
	for <qemu-devel@nongnu.org>; Wed, 06 May 2009 12:36:16 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1241621382-21577-2-git-send-email-glommer@redhat.com>
References: <1241621382-21577-1-git-send-email-glommer@redhat.com>
	<1241621382-21577-2-git-send-email-glommer@redhat.com>
Date: Wed, 6 May 2009 22:36:16 +0300
Message-ID: <f43fc5580905061236l1adf41eicce52055e95bef5b@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] move registering of cpu_reset to inside
	cpu_init
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 5/6/09, Glauber Costa <glommer@redhat.com> wrote:
> This is not pc specific by any means. So we can be
>  moved to inside cpu_x86_init().
>
>  This is part of an attempt to only initialize kvm state
>  after everything is already properly initialized. If we don't
>  do that, we can race against, for example, APIC state if kvm vcpus
>  are ran in threads (happens in qemu-kvm.git, soon to happen here too)

I'd move this too to exec.c. Sparc registers two reset functions, the
first one for the main cpu disables halted state, the second one for
non-boot cpus halts them on reset. I wonder why i386 does not do the
same.