qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Blue Swirl <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure.
Date: Sat, 16 May 2009 09:12:47 +0300	[thread overview]
Message-ID: <f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com> (raw)
In-Reply-To: <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>

On 5/15/09, Anthony Liguori <aliguori@us.ibm.com> wrote:
> From: Paul Brook <paul@codesourcery.com>
>
>  Signed-off-by: Paul Brook <paul@codesourcery.com>

>  +struct DeviceProperty {
>  +    const char *name;
>  +    union {
>  +        int i;

qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.

>  +struct DeviceType {
>  +    const char *name;
>  +    qdev_initfn init;
>  +    void *opaque;
>  +    int size;

size_t size?

>  +DeviceType *qdev_register(const char *name, int size, qdev_initfn init,
>  +                          void *opaque)

size_t size?

>  +void qdev_set_prop_int(DeviceState *dev, const char *name, int value)

>  +uint64_t qdev_get_prop_int(DeviceState *dev, const char *name, uint64_t def)

       reply	other threads:[~2009-05-16  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
2009-05-16  6:12 ` Blue Swirl [this message]
2009-05-17 13:57   ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).