From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M5D8f-0001yo-LF
	for qemu-devel@nongnu.org; Sat, 16 May 2009 02:12:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M5D8b-0001yZ-Uc
	for qemu-devel@nongnu.org; Sat, 16 May 2009 02:12:53 -0400
Received: from [199.232.76.173] (port=57954 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M5D8b-0001yW-R9
	for qemu-devel@nongnu.org; Sat, 16 May 2009 02:12:49 -0400
Received: from mail-fx0-f219.google.com ([209.85.220.219]:50066)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M5D8b-000781-Ir
	for qemu-devel@nongnu.org; Sat, 16 May 2009 02:12:49 -0400
Received: by fxm19 with SMTP id 19so2183652fxm.34
	for <qemu-devel@nongnu.org>; Fri, 15 May 2009 23:12:48 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
References: <200905142138.n4ELcgVW027141@d01av02.pok.ibm.com>
Date: Sat, 16 May 2009 09:12:47 +0300
Message-ID: <f43fc5580905152312q7f664c07tc21243556538dcac@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev
	infrastructure.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 5/15/09, Anthony Liguori <aliguori@us.ibm.com> wrote:
> From: Paul Brook <paul@codesourcery.com>
>
>  Signed-off-by: Paul Brook <paul@codesourcery.com>

>  +struct DeviceProperty {
>  +    const char *name;
>  +    union {
>  +        int i;

qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.

>  +struct DeviceType {
>  +    const char *name;
>  +    qdev_initfn init;
>  +    void *opaque;
>  +    int size;

size_t size?

>  +DeviceType *qdev_register(const char *name, int size, qdev_initfn init,
>  +                          void *opaque)

size_t size?

>  +void qdev_set_prop_int(DeviceState *dev, const char *name, int value)

>  +uint64_t qdev_get_prop_int(DeviceState *dev, const char *name, uint64_t def)