From: Blue Swirl <blauwirbel@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once
Date: Thu, 21 May 2009 21:35:17 +0300 [thread overview]
Message-ID: <f43fc5580905211135o2b4853ffjbc935c6df8ca9084@mail.gmail.com> (raw)
In-Reply-To: <4A158541.8000209@web.de>
On 5/21/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> Anthony Liguori wrote:
> > From: Blue Swirl <blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > Signed-off-by: Blue Swirl <blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > diff --git a/Makefile.hw b/Makefile.hw
> > index 87675fd..6da37a9 100644
> > --- a/Makefile.hw
> > +++ b/Makefile.hw
> > @@ -21,7 +21,13 @@ OBJS+= fw_cfg.o
> > OBJS+= watchdog.o
> > OBJS+= nand.o ecc.o
> >
> > -OBJS+= m48t59.o
> > +OBJS+= m48t59.o escc.o
> > +
> > +# PC style devices
> > +OBJS+= fdc.o
>
> This breaks archs that do not come with DMA_* implementations. At least
> ARM no longer links.
>
> LINK arm-softmmu/qemu-system-arm
> ../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer':
> /data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ'
> [...]
Yes, I forgot about the whole-archive hack. I've disabled it for
hwlib, so now arm-softmmu links.
The whole-archive flag should be used only when needed, otherwise it
will pull in a lot of unnecessary stuff like above.
next prev parent reply other threads:[~2009-05-21 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905211555.n4LFtklw030900@d01av03.pok.ibm.com>
2009-05-21 16:45 ` [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once Jan Kiszka
2009-05-21 18:35 ` Blue Swirl [this message]
2009-05-21 22:32 ` Paul Brook
2009-05-22 15:46 ` Blue Swirl
2009-05-22 15:49 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580905211135o2b4853ffjbc935c6df8ca9084@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).