From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7D6y-0001zB-BA
	for qemu-devel@nongnu.org; Thu, 21 May 2009 14:35:24 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7D6s-0001y0-Qs
	for qemu-devel@nongnu.org; Thu, 21 May 2009 14:35:22 -0400
Received: from [199.232.76.173] (port=45743 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7D6s-0001xx-N7
	for qemu-devel@nongnu.org; Thu, 21 May 2009 14:35:18 -0400
Received: from mail-fx0-f219.google.com ([209.85.220.219]:40579)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M7D6s-0006Yt-39
	for qemu-devel@nongnu.org; Thu, 21 May 2009 14:35:18 -0400
Received: by fxm19 with SMTP id 19so1140870fxm.34
	for <qemu-devel@nongnu.org>; Thu, 21 May 2009 11:35:17 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A158541.8000209@web.de>
References: <200905211555.n4LFtklw030900@d01av03.pok.ibm.com>
	<4A158541.8000209@web.de>
Date: Thu, 21 May 2009 21:35:17 +0300
Message-ID: <f43fc5580905211135o2b4853ffjbc935c6df8ca9084@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc,
	escc and SCSI controllers only once
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 5/21/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> Anthony Liguori wrote:
>  > From: Blue Swirl <blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>  >
>  > Signed-off-by: Blue Swirl <blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>  >
>  > diff --git a/Makefile.hw b/Makefile.hw
>  > index 87675fd..6da37a9 100644
>  > --- a/Makefile.hw
>  > +++ b/Makefile.hw
>  > @@ -21,7 +21,13 @@ OBJS+= fw_cfg.o
>  >  OBJS+= watchdog.o
>  >  OBJS+= nand.o ecc.o
>  >
>  > -OBJS+= m48t59.o
>  > +OBJS+= m48t59.o escc.o
>  > +
>  > +# PC style devices
>  > +OBJS+= fdc.o
>
>  This breaks archs that do not come with DMA_* implementations. At least
>  ARM no longer links.
>
>   LINK  arm-softmmu/qemu-system-arm
>  ../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer':
>  /data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ'
>  [...]

Yes, I forgot about the whole-archive hack. I've disabled it for
hwlib, so now arm-softmmu links.

The whole-archive flag should be used only when needed, otherwise it
will pull in a lot of unnecessary stuff like above.