From: Blue Swirl <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once
Date: Fri, 22 May 2009 18:46:17 +0300 [thread overview]
Message-ID: <f43fc5580905220846u4206b181wc1d2223521530293@mail.gmail.com> (raw)
In-Reply-To: <200905212332.20605.paul@codesourcery.com>
On 5/22/09, Paul Brook <paul@codesourcery.com> wrote:
>
> > > This breaks archs that do not come with DMA_* implementations. At least
> > > ARM no longer links.
> > >
> > > LINK arm-softmmu/qemu-system-arm
> > > ../libhw64/libqemuhw64.a(fdc.o): In function `fdctrl_stop_transfer':
> > > /data/qemu/hw/fdc.c:1086: undefined reference to `DMA_release_DREQ'
> > > [...]
> >
> > Yes, I forgot about the whole-archive hack. I've disabled it for
> > hwlib, so now arm-softmmu links.
>
>
> This is completely wrong. The reason we use whole-archive is so that device
> constructors are run. Most machines are broken after your change.
Did you test? I don't see any breakage, qemu-img --help shows all
block formats and qemu-system-arm -M '?' lists all machines.
Because whole-archive is still used for libqemu_common.a, all devices
in that archive are linked in (whether they are used or not!), so the
constructors work.
next prev parent reply other threads:[~2009-05-22 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905211555.n4LFtklw030900@d01av03.pok.ibm.com>
2009-05-21 16:45 ` [Qemu-devel] Re: [COMMIT e20a8df] Compile fdc, escc and SCSI controllers only once Jan Kiszka
2009-05-21 18:35 ` Blue Swirl
2009-05-21 22:32 ` Paul Brook
2009-05-22 15:46 ` Blue Swirl [this message]
2009-05-22 15:49 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580905220846u4206b181wc1d2223521530293@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).