From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7X2h-0007vy-Sg
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:52:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7X2Q-0007hO-IR
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:52:08 -0400
Received: from [199.232.76.173] (port=42776 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7X2O-0007gT-8u
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:52:00 -0400
Received: from mail-fx0-f219.google.com ([209.85.220.219]:61640)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M7X2N-0000Vs-H4
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:51:59 -0400
Received: by fxm19 with SMTP id 19so1633642fxm.34
	for <qemu-devel@nongnu.org>; Fri, 22 May 2009 08:51:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A1609CD.4000904@codemonkey.ws>
References: <gv4ipi$ani$1@ger.gmane.org> <4A1609CD.4000904@codemonkey.ws>
Date: Fri, 22 May 2009 18:51:57 +0300
Message-ID: <f43fc5580905220851j7277decch2367558633d797ac@mail.gmail.com>
Subject: Re: [Qemu-devel] Windows runtime error
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Consul <void@aleksoft.net>, qemu-devel@nongnu.org

On 5/22/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Consul wrote:
>
> > This commit breaks Windows giving runtime error "Unknown device
> 'virtio-balloon-pci'"
> >
> > ec6bd8dea77478f32981a5df49f66ca2430ad19d
> >
> > Author: Blue Swirl <blauwirbel@gmail.com>  2009-05-21 11:22:59
> > Committer: Blue Swirl <blauwirbel@gmail.com>  2009-05-21 11:22:59
> > Parent: 2567f5796c38238d6f2055f074e347a0338140ce (Compile
> most Xen files only once)
> >
> >    Fix arm-softmmu breakage
> >
> >    Don't use whole-archive for hwlib or libqemu objects
> >
> >    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> >
>  hwlib definitely needs whole-archive.

No, it works fine without it.

>  Why did this break arm-softmmu?  It builds fine for me.

Because fdc.o was forced to be linked in with whole-archive but the
stuff that it depends on may be undefined on ARM. With whole-archive
removed from hwlib, fdc.o is not referenced in anywhere in arm-softmmu
and it will not be pulled in.