Re: [Qemu-devel] Windows runtime error

[Blue Swirl <blauwirbel@gmail.com>]

On 5/22/09, Paul Brook <paul@codesourcery.com> wrote:
> On Friday 22 May 2009, Anthony Liguori wrote:
>  > Paul Brook wrote:
>  > >>>     Don't use whole-archive for hwlib or libqemu objects
>  > >>>
>  > >>>     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>  > >>
>  > >> hwlib definitely needs whole-archive.
>  > >>
>  > >> Why did this break arm-softmmu?  It builds fine for me.
>  > >
>  > > In function `fdctrl_stop_transfer':
>  > > fdc.c:1086: undefined reference to `DMA_release_DREQ'
>  > >
>  > > There appears to be a missing dependency somewhere, I suspect libhw*.a
>  > > doesn't get rebuilt when you move objects from Makefile.target to
>  > > Makefile.hw.
>  >
>  > So a fresh rebuild "fixes" the problem?
>
>
> No, sorry, I mean occasionally you end up with a stale libhw.a.
>
>
>  >Blue, can you revert this commit then?
>
>
> Both this (whole-archive) and the preceding fdc change need to be reverted.

I disagree, whole-archive should only be used very sparingly,
basically for the block/* stuff only. Otherwise most emulators will be
linked with a lot of unnecessary objects files from the archives that
will never be used on that platform.