From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7X66-00019Y-QY
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:55:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7X61-00015g-V2
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:55:50 -0400
Received: from [199.232.76.173] (port=42828 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1M7X61-00015R-La
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:55:45 -0400
Received: from mail-bw0-f175.google.com ([209.85.218.175]:65041)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1M7X61-0000vc-7f
	for qemu-devel@nongnu.org; Fri, 22 May 2009 11:55:45 -0400
Received: by bwz23 with SMTP id 23so1593720bwz.34
	for <qemu-devel@nongnu.org>; Fri, 22 May 2009 08:55:44 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <200905221415.40621.paul@codesourcery.com>
References: <gv4ipi$ani$1@ger.gmane.org>
	<200905221304.53279.paul@codesourcery.com>
	<4A16A38A.40800@codemonkey.ws>
	<200905221415.40621.paul@codesourcery.com>
Date: Fri, 22 May 2009 18:55:43 +0300
Message-ID: <f43fc5580905220855k3146e4a7h89879ea17171d954@mail.gmail.com>
Subject: Re: [Qemu-devel] Windows runtime error
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Consul <void@aleksoft.net>, qemu-devel@nongnu.org

On 5/22/09, Paul Brook <paul@codesourcery.com> wrote:
> On Friday 22 May 2009, Anthony Liguori wrote:
>  > Paul Brook wrote:
>  > >>>     Don't use whole-archive for hwlib or libqemu objects
>  > >>>
>  > >>>     Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>  > >>
>  > >> hwlib definitely needs whole-archive.
>  > >>
>  > >> Why did this break arm-softmmu?  It builds fine for me.
>  > >
>  > > In function `fdctrl_stop_transfer':
>  > > fdc.c:1086: undefined reference to `DMA_release_DREQ'
>  > >
>  > > There appears to be a missing dependency somewhere, I suspect libhw*.a
>  > > doesn't get rebuilt when you move objects from Makefile.target to
>  > > Makefile.hw.
>  >
>  > So a fresh rebuild "fixes" the problem?
>
>
> No, sorry, I mean occasionally you end up with a stale libhw.a.
>
>
>  >Blue, can you revert this commit then?
>
>
> Both this (whole-archive) and the preceding fdc change need to be reverted.

I disagree, whole-archive should only be used very sparingly,
basically for the block/* stuff only. Otherwise most emulators will be
linked with a lot of unnecessary objects files from the archives that
will never be used on that platform.