From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDi8C-0007nL-N7
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 12:55:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDi87-0007gj-CP
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 12:55:31 -0400
Received: from [199.232.76.173] (port=48419 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDi87-0007gO-7P
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 12:55:27 -0400
Received: from mail-bw0-f223.google.com ([209.85.218.223]:52556)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MDi86-000361-HS
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 12:55:27 -0400
Received: by bwz23 with SMTP id 23so2723030bwz.34
	for <qemu-devel@nongnu.org>; Mon, 08 Jun 2009 09:55:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1244478441-26288-1-git-send-email-uril@redhat.com>
References: <1244478441-26288-1-git-send-email-uril@redhat.com>
Date: Mon, 8 Jun 2009 19:55:24 +0300
Message-ID: <f43fc5580906080955i19ad85a5m141b6d2c01d14684@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] exec-migration: handle EINTR in
	popen_get_buffer()
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Uri Lublin <uril@redhat.com>
Cc: qemu-devel@nongnu.org

On 6/8/09, Uri Lublin <uril@redhat.com> wrote:
> Sometimes, upon interrupt, fread returns with no data, and
>  the (incoming exec) migration fails.
>
>  Fix by retrying on such a case.

Maybe a better solution would be to introduce qemu_{f,}{read,write},
which handle EINTR and partial reads/writes.