From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MDign-0005sA-2H
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 13:31:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MDigi-0005lK-6z
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 13:31:16 -0400
Received: from [199.232.76.173] (port=39172 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MDigi-0005kl-0C
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 13:31:12 -0400
Received: from mail-bw0-f223.google.com ([209.85.218.223]:33382)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MDigh-00024f-4f
	for qemu-devel@nongnu.org; Mon, 08 Jun 2009 13:31:11 -0400
Received: by bwz23 with SMTP id 23so2747838bwz.34
	for <qemu-devel@nongnu.org>; Mon, 08 Jun 2009 10:31:10 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090608120229.GD27210@redhat.com>
References: <20090608120229.GD27210@redhat.com>
Date: Mon, 8 Jun 2009 20:31:09 +0300
Message-ID: <f43fc5580906081031y5fefa35cr80672d8c8905da50@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] remove unused field from pci device.
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: qemu-devel@nongnu.org

On 6/8/09, Gleb Natapov <gleb@redhat.com> wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>  diff --git a/hw/pci.c b/hw/pci.c
>  index 0ab5b94..02b335f 100644
>  --- a/hw/pci.c
>  +++ b/hw/pci.c
>  @@ -268,7 +268,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
>          config_write = pci_default_write_config;
>      pci_dev->config_read = config_read;
>      pci_dev->config_write = config_write;
>  -    pci_dev->irq_index = pci_irq_index++;
>  +    pci_irq_index++;
>      bus->devices[devfn] = pci_dev;
>      pci_dev->irq = qemu_allocate_irqs(pci_set_irq, pci_dev, 4);
>      return pci_dev;
>  diff --git a/hw/pci.h b/hw/pci.h
>  index 0405837..fb7b89a 100644
>  --- a/hw/pci.h
>  +++ b/hw/pci.h
>  @@ -154,8 +154,6 @@ struct PCIDevice {
>      PCIConfigReadFunc *config_read;
>      PCIConfigWriteFunc *config_write;
>      PCIUnregisterFunc *unregister;
>  -    /* ??? This is a PC-specific hack, and should be removed.  */
>  -    int irq_index;
>
>      /* IRQ objects for the INTA-INTD pins.  */
>      qemu_irq *irq;

After the patch, pci_irq_index no longer tracks irqs but how many PCI
devices there are in the system, so perhaps it should be renamed as
well.