From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME3rV-0003aJ-4P for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:07:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME3rQ-0003M1-E3 for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:07:44 -0400 Received: from [199.232.76.173] (port=50264 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME3rQ-0003Ld-2w for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:07:40 -0400 Received: from mail-fx0-f219.google.com ([209.85.220.219]:38337) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ME3rP-0008IZ-8x for qemu-devel@nongnu.org; Tue, 09 Jun 2009 12:07:39 -0400 Received: by fxm19 with SMTP id 19so89938fxm.34 for ; Tue, 09 Jun 2009 09:07:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20090609155321.GM5558@redhat.com> References: <1244465766-6349-1-git-send-email-gleb@redhat.com> <1244465766-6349-2-git-send-email-gleb@redhat.com> <4A2D219F.1020408@redhat.com> <20090608143710.GM27210@redhat.com> <4A2D85B8.1090301@redhat.com> <20090609053154.GO27210@redhat.com> <20090609155321.GM5558@redhat.com> Date: Tue, 9 Jun 2009 19:07:34 +0300 Message-ID: Subject: Re: [Qemu-devel] [PATCH 2/3] Add pci_bus_reset() function. From: Blue Swirl Content-Type: multipart/mixed; boundary=001485f5ce6a8ee421046bec8eec List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Yaniv Kamay , Dor Laor , Avi Kivity , qemu-devel@nongnu.org --001485f5ce6a8ee421046bec8eec Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/9/09, Gleb Natapov wrote: > On Tue, Jun 09, 2009 at 06:07:00PM +0300, Blue Swirl wrote: > > > Here's a 5 min patch to add reset to e1000 and rtl8139. Not too difficult? > > > > By the way I see that you don't lower irq line in e1000 reset handler > (haven't looked at rtl8139 one). Also on loadvm the irq line should be toggled. Fixed in this patch. --001485f5ce6a8ee421046bec8eec Content-Type: application/x-patch; name="0001-Update-irqs-on-reset-and-device-load.patch" Content-Disposition: attachment; filename="0001-Update-irqs-on-reset-and-device-load.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fvqt10yk RnJvbSAzYWIwMzMwMTZjYmRmYTUwNzljMTg3OTQ2OTkyZGE5ZDdjNDE0OTJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCbHVlIFN3aXJsIDxibGF1d2lyYmVsQGdtYWlsLmNvbT4KRGF0 ZTogVHVlLCA5IEp1biAyMDA5IDE2OjAzOjQxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gVXBkYXRl IGlycXMgb24gcmVzZXQgYW5kIGRldmljZSBsb2FkCgpTaWduZWQtb2ZmLWJ5OiBCbHVlIFN3aXJs IDxibGF1d2lyYmVsQGdtYWlsLmNvbT4KLS0tCiBody9lMTAwMC5jIHwgICAxMCArKysrKysrKyst CiAxIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9ody9lMTAwMC5jIGIvaHcvZTEwMDAuYwppbmRleCBhMDRkN2IxLi4wM2ZhZDRjIDEw MDY0NAotLS0gYS9ody9lMTAwMC5jCisrKyBiL2h3L2UxMDAwLmMKQEAgLTE1MCwxMiArMTUwLDE4 IEBAIGlvcG9ydF9tYXAoUENJRGV2aWNlICpwY2lfZGV2LCBpbnQgcmVnaW9uX251bSwgdWludDMy X3QgYWRkciwKIH0KIAogc3RhdGljIHZvaWQKK3VwZGF0ZV9pcnFzKEUxMDAwU3RhdGUgKnMpCit7 CisgICAgcWVtdV9zZXRfaXJxKHMtPmRldi5pcnFbMF0sIChzLT5tYWNfcmVnW0lNU10gJiBzLT5t YWNfcmVnW0lDUl0pICE9IDApOworfQorCitzdGF0aWMgdm9pZAogc2V0X2ludGVycnVwdF9jYXVz ZShFMTAwMFN0YXRlICpzLCBpbnQgaW5kZXgsIHVpbnQzMl90IHZhbCkKIHsKICAgICBpZiAodmFs KQogICAgICAgICB2YWwgfD0gRTEwMDBfSUNSX0lOVF9BU1NFUlRFRDsKICAgICBzLT5tYWNfcmVn W0lDUl0gPSB2YWw7Ci0gICAgcWVtdV9zZXRfaXJxKHMtPmRldi5pcnFbMF0sIChzLT5tYWNfcmVn W0lNU10gJiBzLT5tYWNfcmVnW0lDUl0pICE9IDApOworICAgIHVwZGF0ZV9pcnFzKHMpOwogfQog CiBzdGF0aWMgdm9pZApAQCAtOTcwLDYgKzk3Niw3IEBAIG5pY19sb2FkKFFFTVVGaWxlICpmLCB2 b2lkICpvcGFxdWUsIGludCB2ZXJzaW9uX2lkKQogICAgICAgICBmb3IgKGogPSAwOyBqIDwgbWFj X3JlZ2FycmF5c3Rvc2F2ZVtpXS5zaXplOyBqKyspCiAgICAgICAgICAgICBxZW11X2dldF9iZTMy cyhmLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgcy0+bWFjX3JlZyArIG1hY19yZWdhcnJh eXN0b3NhdmVbaV0uYXJyYXkwICsgaik7CisgICAgdXBkYXRlX2lycXMocyk7CiAgICAgcmV0dXJu IDA7CiB9CiAKQEAgLTEwNjgsNiArMTA3NSw3IEBAIHN0YXRpYyB2b2lkIGUxMDAwX3Jlc2V0KHZv aWQgKm9wYXF1ZSkKICAgICBtZW1tb3ZlKGQtPm1hY19yZWcsIG1hY19yZWdfaW5pdCwgc2l6ZW9m IG1hY19yZWdfaW5pdCk7CiAgICAgZC0+cnhidWZfbWluX3NoaWZ0ID0gMTsKICAgICBtZW1zZXQo JmQtPnR4LCAwLCBzaXplb2YgZC0+dHgpOworICAgIHVwZGF0ZV9pcnFzKGQpOwogfQogCiBzdGF0 aWMgdm9pZCBwY2lfZTEwMDBfaW5pdChQQ0lEZXZpY2UgKnBjaV9kZXYpCi0tIAoxLjUuNi41Cgo= --001485f5ce6a8ee421046bec8eec--