From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MER9n-0003WM-3D
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 13:00:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MER9i-0003Uc-FO
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 13:00:10 -0400
Received: from [199.232.76.173] (port=49755 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MER9i-0003UU-74
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 13:00:06 -0400
Received: from mail-bw0-f223.google.com ([209.85.218.223]:63410)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MER9h-0004o9-Ph
	for qemu-devel@nongnu.org; Wed, 10 Jun 2009 13:00:05 -0400
Received: by bwz23 with SMTP id 23so801792bwz.34
	for <qemu-devel@nongnu.org>; Wed, 10 Jun 2009 10:00:04 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090609182457.2d7a22dc@redhat.com>
References: <20090609182457.2d7a22dc@redhat.com>
Date: Wed, 10 Jun 2009 20:00:04 +0300
Message-ID: <f43fc5580906101000se2d52a7u56f64c6c701a7a5b@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Fix "defined but not used" warning
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On 6/10/09, Luiz Capitulino <lcapitulino@redhat.com> wrote:
>
>  The function qemu_calculate_timeout() is only used when CONFIG_IOTHREAD
>  is not defined. When CONFIG_IOTHREAD is defined, we have the following
>  warning:
>
>  vl.c:4389: warning: =E2=80=98qemu_calculate_timeout=E2=80=99 defined but=
 not used
>
>  This change fixes that by moving the #ifdef/#endif from main_loop()
>  into qemu_calculate_timeout(). This encapsulates the logic and allow
>  us to use qemu_calculate_timeout() when CONFIG_IOTHREAD is defined
>  or not (suggested by Glauber Costa).
>
>  Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Thanks, applied.