From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MEmoN-0007ge-4F
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 12:07:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MEmoL-0007gD-Nt
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 12:07:30 -0400
Received: from [199.232.76.173] (port=40182 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MEmoL-0007g6-ID
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 12:07:29 -0400
Received: from fg-out-1718.google.com ([72.14.220.152]:55824)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MEmoL-0006bp-1g
	for qemu-devel@nongnu.org; Thu, 11 Jun 2009 12:07:29 -0400
Received: by fg-out-1718.google.com with SMTP id l27so1392401fgb.8
	for <qemu-devel@nongnu.org>; Thu, 11 Jun 2009 09:07:27 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090611135155.GA13426@amit-x200.pnq.redhat.com>
References: <1244565768-9103-1-git-send-email-amit.shah@redhat.com>
	<1244565768-9103-2-git-send-email-amit.shah@redhat.com>
	<1244565768-9103-3-git-send-email-amit.shah@redhat.com>
	<1244565768-9103-4-git-send-email-amit.shah@redhat.com>
	<20090609181714.GB11485@amd.home.annexia.org>
	<4A2EB079.6020909@codemonkey.ws>
	<20090611135155.GA13426@amit-x200.pnq.redhat.com>
Date: Thu, 11 Jun 2009 19:07:26 +0300
Message-ID: <f43fc5580906110907h341a4237pafefdfcac4e4b9ee@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-serial: PCI device for simple host
	<-> guest communication
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: "Richard W.M. Jones" <rjones@redhat.com>, qemu-devel@nongnu.org

On 6/11/09, Amit Shah <amit.shah@redhat.com> wrote:
> On (Tue) Jun 09 2009 [13:56:57], Anthony Liguori wrote:
>  > Richard W.M. Jones wrote:
>  >> On Tue, Jun 09, 2009 at 10:12:48PM +0530, Amit Shah wrote:
>  >> [...]
>  >>
>  >> Are you going to post the virtio driver for the Linux kernel later?
>  >>
>  >
>  > Yeah, I'd like to see the Linux driver before drawing conclusions.
>
>  Pasting here a slightly older version of the patch. I'm actively working
>  on it; a few things might have changed but the basic idea remains the
>  same.

>  + * along with this program; if not, write to the Free Software
>  + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

Old FSF address, the new one is on Franklin St.

>  +struct virtio_serial_port {

>  +       unsigned int read_len;

This limits the maximum transfer length to 4G, which is way too short
on 64 bit hosts. ;-)

>  +struct virtio_serial_config {
>  +       __u8 nr_ports;
>  +       __u16 status;
>  +} __attribute__((packed));

The structure should be redesigned to work without packed attribute.
status field is unaligned.