From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MFrXa-00065U-VO
	for qemu-devel@nongnu.org; Sun, 14 Jun 2009 11:22:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MFrXa-000653-FC
	for qemu-devel@nongnu.org; Sun, 14 Jun 2009 11:22:38 -0400
Received: from [199.232.76.173] (port=58669 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MFrXa-00064r-5i
	for qemu-devel@nongnu.org; Sun, 14 Jun 2009 11:22:38 -0400
Received: from fg-out-1718.google.com ([72.14.220.155]:7843)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MFrXZ-0005ad-OO
	for qemu-devel@nongnu.org; Sun, 14 Jun 2009 11:22:37 -0400
Received: by fg-out-1718.google.com with SMTP id l27so267201fgb.8
	for <qemu-devel@nongnu.org>; Sun, 14 Jun 2009 08:22:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <f4b26d5b1a696e25e9324707eecb241906f50426.1244813287.git.riku.voipio@iki.fi>
References: <cover.1244813287.git.riku.voipio@iki.fi>
	<f4b26d5b1a696e25e9324707eecb241906f50426.1244813287.git.riku.voipio@iki.fi>
Date: Sun, 14 Jun 2009 18:22:36 +0300
Message-ID: <f43fc5580906140822o31dbe429ma96794ac2baf7dd5@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 08/21] Fix struct termios host - target
	translation
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "riku.voipio@iki.fi" <riku.voipio@iki.fi>
Cc: qemu-devel@nongnu.org

On 6/12/09, riku.voipio@iki.fi <riku.voipio@iki.fi> wrote:
> From: Arnaud Patard <arnaud.patard@rtp-net.org>
>
>  When converting the termios structure between host and target in
>  target_to_host_termios and host_to_target_termios, the c_cc[] array is
>  never initialised.
>  Calling memset() before using it allows to run successfully "stty echo /
>  stty -echo" on arm-linux-user target (host being x86 and mips).
>
>  From: Arnaud Patard <arnaud.patard@rtp-net.org>
>  Signed-off-by: Riku Voipio <riku.voipio@iki.fi>

>>From != SOB.