From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGbWc-00032K-VW
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 12:28:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGbWY-00031p-A5
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 12:28:42 -0400
Received: from [199.232.76.173] (port=45280 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGbWY-00031l-1J
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 12:28:38 -0400
Received: from mail-fx0-f209.google.com ([209.85.220.209]:34110)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MGbWX-0001sV-FM
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 12:28:37 -0400
Received: by fxm5 with SMTP id 5so1479421fxm.34
	for <qemu-devel@nongnu.org>; Tue, 16 Jun 2009 09:28:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A37896C.8050208@redhat.com>
References: <4A37896C.8050208@redhat.com>
Date: Tue, 16 Jun 2009 19:28:36 +0300
Message-ID: <f43fc5580906160928k48af1cd0kf54717764eddfa58@mail.gmail.com>
Subject: Re: [Qemu-devel] Regression opening read-only cdroms
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel <qemu-devel@nongnu.org>

On 6/16/09, Avi Kivity <avi@redhat.com> wrote:
> qemu used to be quite happy opening read-only cdrom images, and I was quite
> happy feeding kvm-autotest a library of read-only iso images.  However since
>
>    commit 0e1d8f4c549e51fd19793a154862979fdc199477
>    Author: Christoph Hellwig <hch@lst.de>
>    Date:   Mon Jun 15 13:53:26 2009 +0200
>
>         raw-posix: always store open flags
>
>         Both the Linux floppy and the FreeBSD CDROM host device need to
>    store
>         the open flags so that they can re-open the device later.   Store
> the
>         open flags unconditionally to remove the ifdef mess and simply the
>         calling conventions for the later patches in the series.
>
>         Signed-off-by: Christoph Hellwig <hch@lst.de>
>
>  this state of happiness no longer exists.
>
>  Can you look at what caused this?

How about these:
- open_flags = O_BINARY;
+ s->open_flags |= O_BINARY;
- open_flags = O_BINARY;
+ s->open_flags |= O_BINARY;