Re: [Qemu-devel] Regression opening read-only cdroms

[Blue Swirl <blauwirbel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On 6/16/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On 6/16/09, Avi Kivity <avi@redhat.com> wrote:
>  > qemu used to be quite happy opening read-only cdrom images, and I was quite
>  > happy feeding kvm-autotest a library of read-only iso images.  However since
>  >
>  >    commit 0e1d8f4c549e51fd19793a154862979fdc199477
>  >    Author: Christoph Hellwig <hch@lst.de>
>  >    Date:   Mon Jun 15 13:53:26 2009 +0200
>  >
>  >         raw-posix: always store open flags
>  >
>  >         Both the Linux floppy and the FreeBSD CDROM host device need to
>  >    store
>  >         the open flags so that they can re-open the device later.   Store
>  > the
>  >         open flags unconditionally to remove the ifdef mess and simply the
>  >         calling conventions for the later patches in the series.
>  >
>  >         Signed-off-by: Christoph Hellwig <hch@lst.de>
>  >
>  >  this state of happiness no longer exists.
>  >
>  >  Can you look at what caused this?
>
>
> How about these:
>  - open_flags = O_BINARY;
>  + s->open_flags |= O_BINARY;
>  - open_flags = O_BINARY;
>  + s->open_flags |= O_BINARY;

Fix attached, could you test it?

[-- Attachment #2: 0001-Fix-opening-of-read-only-raw-images.patch --]
[-- Type: application/x-patch, Size: 4031 bytes --]