Re: [Qemu-devel] [PATCH] cocoa.m issues fixed

[Blue Swirl <blauwirbel@gmail.com>]

On 6/21/09, Avi Kivity <avi@redhat.com> wrote:
> On 06/21/2009 05:06 PM, G 3 wrote:
>
> >
> > On Jun 21, 2009, at 6:10 AM, Andreas Färber wrote:
> >
> >
> > >
> > > Am 21.06.2009 um 03:19 schrieb G 3:
> > >
> > >
> > > > +int cocoa_keycode_to_qemu(int keycode);
> > > > +
> > > >
> > >
> > > This seems unrelated. I believe you're trying to suppress a warning I've
> been seeing on 10.5 as well - if so, please provide that as a separate patch
> with appropriate description.
> > >
> > >
> >
> > This function prototype would eliminate this warning:
> > cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu'
> >
> > Why a separate patch. Why not kill two birds with one stone?
> >
>
>  It's standard operating procedure.  Suppose in addition to the two birds
> you mention the patch also kills an innocent kitten.  Since it's one patch,
> if a fix is not immediately forthcoming, the maintainer has to revert the
> patch, bringing both birds back to life.

How nasty for you to forget the poor little kitten, who should be
entitled to get her life back.

>  With one patch per bird, the maintainer can revert just the patch which
> killed the kitten, leaving the other bird dead.

Also here, do you really hate kittens that much? ;-)