From: Blue Swirl <blauwirbel@gmail.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH] virtio_serial: A char device for simple guest <-> host communication
Date: Tue, 23 Jun 2009 18:15:18 +0300 [thread overview]
Message-ID: <f43fc5580906230815o219e3676x2fa078c9ed9db15a@mail.gmail.com> (raw)
In-Reply-To: <1245760953-32139-2-git-send-email-amit.shah@redhat.com>
On 6/23/09, Amit Shah <amit.shah@redhat.com> wrote:
> We expose multiple char devices ("ports") for simple communication
> between the host userspace and guest.
> +struct virtio_serial_config {
> + __u32 nr_ports;
> + __u16 status;
> +} __attribute__((packed));
There is still structure packing. I'd use __u16 for both fields, do
you really need 4 gigs of ports?.
next prev parent reply other threads:[~2009-06-23 15:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 12:42 [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication Amit Shah
2009-06-23 12:42 ` [Qemu-devel] [PATCH] virtio_serial: A char device for simple guest <-> host communication Amit Shah
2009-06-23 12:42 ` [Qemu-devel] [PATCH] virtio-serial: virtio device for simple host <-> guest communication Amit Shah
2009-06-23 15:19 ` Blue Swirl
2009-06-23 15:15 ` Blue Swirl [this message]
2009-06-23 12:55 ` [Qemu-devel] virtio-serial: A guest <-> host interface for simple communication Paul Brook
2009-06-23 13:00 ` Amit Shah
2009-06-23 13:09 ` Paul Brook
2009-06-23 13:58 ` Christian Bornträger
2009-06-23 14:16 ` Paul Brook
2009-06-23 14:40 ` Christian Bornträger
2009-06-23 14:59 ` Daniel P. Berrange
2009-06-24 4:15 ` [Qemu-devel] " Rusty Russell
2009-06-24 12:39 ` Amit Shah
2009-06-25 11:33 ` Rusty Russell
2009-06-25 20:49 ` Amit Shah
2009-06-24 16:40 ` [Qemu-devel] " Jamie Lokier
2009-06-24 17:10 ` Amit Shah
2009-06-24 17:50 ` Jamie Lokier
2009-06-24 18:01 ` Amit Shah
2009-06-24 19:20 ` Jamie Lokier
2009-06-25 4:41 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580906230815o219e3676x2fa078c9ed9db15a@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).