From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ7iX-00073y-7z
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:15:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ7iW-00072F-09
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:15:24 -0400
Received: from [199.232.76.173] (port=58515 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ7iV-000725-QV
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:15:23 -0400
Received: from fg-out-1718.google.com ([72.14.220.159]:40819)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MJ7iV-0000Sw-54
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:15:23 -0400
Received: by fg-out-1718.google.com with SMTP id l27so888288fgb.8
	for <qemu-devel@nongnu.org>; Tue, 23 Jun 2009 08:15:19 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1245760953-32139-2-git-send-email-amit.shah@redhat.com>
References: <1245760953-32139-1-git-send-email-amit.shah@redhat.com>
	<1245760953-32139-2-git-send-email-amit.shah@redhat.com>
Date: Tue, 23 Jun 2009 18:15:18 +0300
Message-ID: <f43fc5580906230815o219e3676x2fa078c9ed9db15a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] virtio_serial: A char device for simple
	guest <-> host communication
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org

On 6/23/09, Amit Shah <amit.shah@redhat.com> wrote:
> We expose multiple char devices ("ports") for simple communication
>  between the host userspace and guest.
>  +struct virtio_serial_config {
>  +       __u32 nr_ports;
>  +       __u16 status;
>  +} __attribute__((packed));

There is still structure packing. I'd use __u16 for both fields, do
you really need 4 gigs of ports?.