From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MM68L-00075N-QY
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 16:10:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MM68H-000733-39
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 16:10:21 -0400
Received: from [199.232.76.173] (port=48372 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MM68H-000730-00
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 16:10:17 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:38344)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MM68G-0001MZ-US
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 16:10:17 -0400
Received: by fxm7 with SMTP id 7so993997fxm.34
	for <qemu-devel@nongnu.org>; Wed, 01 Jul 2009 13:10:15 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A4BBFAE.5090401@web.de>
References: <200906300055.n5U0tADj013302@d03av01.boulder.ibm.com>
	<f43fc5580907011226p5ffac058n26d3d19b74160567@mail.gmail.com>
	<4A4BBE84.9020405@us.ibm.com> <4A4BBFAE.5090401@web.de>
Date: Wed, 1 Jul 2009 23:10:15 +0300
Message-ID: <f43fc5580907011310i35d9df6ci4ff3224387c2ccab@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 059b8b1] KVM: x86: Refactor
	persistent CPU state
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 7/1/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> Anthony Liguori wrote:
>  > Blue Swirl wrote:
>  >> On 6/30/09, Anthony Liguori <aliguori@us.ibm.com> wrote:
>  >>
>  >>> From: Jan Kiszka <jan.kiszka@web.de>
>  >>>
>  >>>  This patch aligns the KVM-related layout and encoding of the CPU state
>  >>>  to be saved to disk or migrated with qemu-kvm. The major differences
>  >>> are
>  >>>  reordering of fields and a compressed interrupt_bitmap into a single
>  >>>  number as there can be no more than one pending IRQ at a time.
>  >>>
>  >>>  Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>  >>>  Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>  >>>
>  >>
>  >>
>  >>>  +    for (i = 0; i < ARRAY_SIZE(env->interrupt_bitmap); i++) {
>  >>>  +        bit = ffsll(env->interrupt_bitmap[i]);
>  >>>
>  >>
>  >> This broke build on platforms without ffsll (Mingw32, *BSDs).
>  >>
>  >
>  > What version of mingw32?  Mine seems to have ffsll (gcc 4.4.2).
>  >
>  > Jan, can you send a patch to fix this?
>  >
>
>
> I'm currently checking the mingw situation. I likely missed the warning,
>  but it seems to link - looking for the header...
>
>  Can anyone comment on the BSD situation? I have no test env for such
>  platforms.

Grepping for ffsll in /usr/include does not find anything, there is no
man page either.

We could add a local qemu_ffsll (or qemu_ffs64) to osdep.c or cutils.c.