From: Blue Swirl <blauwirbel@gmail.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Use ffs in favor of ffsll
Date: Wed, 1 Jul 2009 23:27:51 +0300 [thread overview]
Message-ID: <f43fc5580907011327y513f19aes1de918a6bf40257e@mail.gmail.com> (raw)
In-Reply-To: <4A4BC57E.504@web.de>
On 7/1/09, Jan Kiszka <jan.kiszka@web.de> wrote:
> Not all host platforms support the ll variant. This is not a critical
> path, so go the easy way.
> - for (i = 0; i < ARRAY_SIZE(env->interrupt_bitmap); i++) {
> - bit = ffsll(env->interrupt_bitmap[i]);
> + for (i = 0; i < sizeof(env->interrupt_bitmap) / sizeof(int); i++) {
> + bit = ffs(((int *)env->interrupt_bitmap)[i]);
> if (bit) {
> - pending_irq = i * 64 + bit - 1;
> + pending_irq = i * 8 * sizeof(int) + bit - 1;
I think this will not work on a big endian host.
next prev parent reply other threads:[~2009-07-01 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 20:22 [Qemu-devel] [PATCH] Use ffs in favor of ffsll Jan Kiszka
2009-07-01 20:27 ` Blue Swirl [this message]
2009-07-01 20:35 ` [Qemu-devel] " Jan Kiszka
2009-07-01 20:55 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2009-07-01 20:58 ` Nathan Froyd
2009-07-01 22:24 ` [Qemu-devel] " Jan Kiszka
2009-07-01 23:02 ` [Qemu-devel] " Stuart Brady
2009-07-02 7:04 ` [Qemu-devel] [PATCH] Use ctz64 " Jan Kiszka
2009-07-02 7:11 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2009-07-03 9:35 ` Paul Brook
2009-07-04 7:16 ` Jan Kiszka
2009-07-02 8:39 ` [Qemu-devel] Re: [PATCH] Use ffs " Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580907011327y513f19aes1de918a6bf40257e@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).