From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNPFI-0004n0-7I
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:46:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNPFH-0004m8-Er
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:46:55 -0400
Received: from [199.232.76.173] (port=41345 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNPFH-0004lw-5v
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:46:55 -0400
Received: from fg-out-1718.google.com ([72.14.220.155]:1423)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MNPFG-0007ot-Pg
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:46:54 -0400
Received: by fg-out-1718.google.com with SMTP id l27so396500fgb.8
	for <qemu-devel@nongnu.org>; Sun, 05 Jul 2009 03:46:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090705102423.GA3833@redhat.com>
References: <cover.1246782566.git.mst@redhat.com>
	<20090705102423.GA3833@redhat.com>
Date: Sun, 5 Jul 2009 13:46:53 +0300
Message-ID: <f43fc5580907050346u54388719n27f53d7cead8c9b1@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com

On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> This fixes segfault reported by Kevin Wolf,
>  and simplifies the code in msix_save.

>  +    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
>  +        return;

Dubious: !x & y. You also forgot the braces.