From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNQRu-0003pv-Aw
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:04:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNQRp-0003f6-I1
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:04:01 -0400
Received: from [199.232.76.173] (port=33468 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNQRp-0003e8-67
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:03:57 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:56643)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MNQRo-00023N-Ii
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 08:03:56 -0400
Received: by fxm7 with SMTP id 7so2883833fxm.34
	for <qemu-devel@nongnu.org>; Sun, 05 Jul 2009 05:03:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090705115601.GA4826@redhat.com>
References: <cover.1246793893.git.mst@redhat.com>
	<20090705114057.GE4798@redhat.com>
	<f43fc5580907050448w6a254762y51d57f192978da3b@mail.gmail.com>
	<20090705115601.GA4826@redhat.com>
Date: Sun, 5 Jul 2009 15:03:55 +0300
Message-ID: <f43fc5580907050503m15153f98j5aa82f27ce073729@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, glommer@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Sun, Jul 05, 2009 at 02:48:12PM +0300, Blue Swirl wrote:
>  > On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
>  > > MSIX present bit is tested incorrectly, and only happens to work because
>  > >  the bit we are testing is 0x1.  Add braces to fix this.
>  > >
>  > >  Reported-by: Blue Swirl <blauwirbel@gmail.com>
>  > >  Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>  > >  ---
>  > >   hw/msix.c |    2 +-
>  > >   1 files changed, 1 insertions(+), 1 deletions(-)
>  > >
>  > >  diff --git a/hw/msix.c b/hw/msix.c
>  > >  index 33549f5..db72cc3 100644
>  > >  --- a/hw/msix.c
>  > >  +++ b/hw/msix.c
>  > >  @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
>  > >   {
>  > >      unsigned n = dev->msix_entries_nr;
>  > >
>  > >  -    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
>  > >  +    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX))
>  >
>  > With the braces comment I meant that while working on the code, you
>  > should update it to match CODING_STYLE:
>  > if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
>  >     return;
>  > }
>
>
> Yea ... it's probably better to do this all over the file, not piecewise,
>  though. No?

I think it's better to do it together with other changes:
http://lists.gnu.org/archive/html/qemu-devel/2009-05/msg00925.html