From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNY4u-0006K6-Hp
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 16:12:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNY4t-0006Ju-4s
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 16:12:47 -0400
Received: from [199.232.76.173] (port=40795 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNY4s-0006Jr-VY
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 16:12:47 -0400
Received: from fg-out-1718.google.com ([72.14.220.154]:23880)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MNY4s-0007zE-Eb
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 16:12:46 -0400
Received: by fg-out-1718.google.com with SMTP id d23so1163751fga.8
	for <qemu-devel@nongnu.org>; Sun, 05 Jul 2009 13:12:45 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20090705194735.GB4043@redhat.com>
References: <cover.1246782566.git.mst@redhat.com>
	<20090705102423.GA3833@redhat.com>
	<20090705104516.GA1555@miranda.arrow>
	<20090705194735.GB4043@redhat.com>
Date: Sun, 5 Jul 2009 23:12:45 +0300
Message-ID: <f43fc5580907051312t2c102308o67aca07df9cc9dcf@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Sun, Jul 05, 2009 at 11:45:17AM +0100, Stuart Brady wrote:
>  > On Sun, Jul 05, 2009 at 01:24:24PM +0300, Michael S. Tsirkin wrote:
>  > > +    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
>  > > +        return;
>  >
>  > Same bug as fixed by 98846d7 ('Fix Sparse warning').
>  >
>  > Should be:
>  >
>  >     if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
>  >         return;
>  >     }
>  >
>  > Cheers,
>
>  BTW what's the command to run sparse on qemu?

Just install sparse (sparse and cgcc) somewhere along $PATH, then
configure with --enable-sparse. Rebuild QEMU, sparse will be used as a
wrapper for real GCC.