From: Blue Swirl <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348
Date: Fri, 10 Jul 2009 22:10:43 +0300 [thread overview]
Message-ID: <f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com> (raw)
Hi,
APB is not converted to qdev yet, so pci_register_secondary_bus
shouldn't use FROM_QBUS. Sparc64 is currently broken.
Partially reverting 16eaed... fixes the breakage:
diff --git a/hw/pci.c b/hw/pci.c
index 71d9227..f592925 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -135,7 +135,7 @@ static PCIBus
*pci_register_secondary_bus(PCIDevice *dev, pci_map_irq_fn map_irq
{
PCIBus *bus;
- bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
+ bus = qemu_mallocz(sizeof(PCIBus));
bus->map_irq = map_irq;
bus->parent_dev = dev;
bus->next = dev->bus->next;
next reply other threads:[~2009-07-10 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-10 19:10 Blue Swirl [this message]
2009-07-10 19:36 ` [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348 Anthony Liguori
2009-07-10 19:47 ` Gerd Hoffmann
2009-07-10 19:48 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).