From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPM5T-0003kz-NU
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:48:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPM5S-0003jQ-MX
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:48:51 -0400
Received: from [199.232.76.173] (port=48058 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPM5S-0003jK-Jc
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:48:50 -0400
Received: from fg-out-1718.google.com ([72.14.220.158]:2200)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MPM5R-00076n-Vr
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 15:48:50 -0400
Received: by fg-out-1718.google.com with SMTP id d23so414823fga.8
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 12:48:47 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4A579828.6010000@codemonkey.ws>
References: <f43fc5580907101210v7138d10awacdf006069283598@mail.gmail.com>
	<4A579828.6010000@codemonkey.ws>
Date: Fri, 10 Jul 2009 22:48:47 +0300
Message-ID: <f43fc5580907101248pe50d442x1e72fcd5eada5b04@mail.gmail.com>
Subject: Re: [Qemu-devel] Sparc64 breakage by
	16eaedf2668e9b347a59d73346fcc4c764c58348
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

On 7/10/09, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Blue Swirl wrote:
>
> > Hi,
> >
> > APB is not converted to qdev yet, so pci_register_secondary_bus
> > shouldn't use FROM_QBUS. Sparc64 is currently broken.
> >
> > Partially reverting 16eaed... fixes the breakage:
> > diff --git a/hw/pci.c b/hw/pci.c
> > index 71d9227..f592925 100644
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > @@ -135,7 +135,7 @@ static PCIBus
> > *pci_register_secondary_bus(PCIDevice *dev,
> pci_map_irq_fn map_irq
> >  {
> >     PCIBus *bus;
> >
> > -    bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev,
> NULL));
> > +    bus = qemu_mallocz(sizeof(PCIBus));
> >     bus->map_irq = map_irq;
> >     bus->parent_dev = dev;
> >     bus->next = dev->bus->next;
> >
> >
>
>  Gerd, could you take a look?
>
>  Blue, you mentioned that you have an openbios-sparc64 image for testing?
> Would that have uncovered this and if so, do you have a link handy?

We deliver the latest (r505) OpenBIOS image at pc-bios/openbios-sparc64.

To test this bug, the following is enough:
./obj-amd64/sparc64-softmmu/qemu-system-sparc64 -L ./pc-bios/
Segmentation fault

With my patch applied, you get the OpenBIOS Forth prompt.