[Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Igor Kovalenko]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

It is clear that intention is to byte-swap value to be written, not
the target address.
Please apply.

-- 
Kind regards,
Igor V. Kovalenko

[-- Attachment #2: sparc64-le-typo --]
[-- Type: application/octet-stream, Size: 1147 bytes --]

Index: qemu-trunk/target-sparc/op_helper.c
===================================================================
--- qemu-trunk.orig/target-sparc/op_helper.c
+++ qemu-trunk/target-sparc/op_helper.c
@@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            addr = bswap16(val);
             break;
         case 4:
-            addr = bswap32(addr);
+            addr = bswap32(val);
             break;
         case 8:
-            addr = bswap64(addr);
+            addr = bswap64(val);
             break;
         default:
             break;
@@ -2375,13 +2375,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            val = bswap16(val);
             break;
         case 4:
-            addr = bswap32(addr);
+            val = bswap32(val);
             break;
         case 8:
-            addr = bswap64(addr);
+            val = bswap64(val);
             break;
         default:
             break;

Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Stuart Brady]

On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
> It is clear that intention is to byte-swap value to be written, not
> the target address.

@@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            addr = bswap16(val);
             ^^^^
Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
64-bit cases)?  Also needs a 'signed-off-by:'...

Cheers,
-- 
Stuart Brady

Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Igor Kovalenko]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady<sdbrady@ntlworld.com> wrote:
> On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
>> It is clear that intention is to byte-swap value to be written, not
>> the target address.
>
> @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
>     case 0x89: // Secondary LE
>         switch(size) {
>         case 2:
> -            addr = bswap16(addr);
> +            addr = bswap16(val);
>             ^^^^
> Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
> 64-bit cases)?  Also needs a 'signed-off-by:'...
>
> Cheers,
> --
> Stuart Brady
>

Thanks, that part I did not runtime-tested.
Not sure if those asi stores are of any use for user-mode emulator.

Please find attached the corrected version.

Signed-off-by: igor.v.kovalenko@gmail.com

-- 
Kind regards,
Igor V. Kovalenko

[-- Attachment #2: sparc64-le-typo --]
[-- Type: application/octet-stream, Size: 1144 bytes --]

Index: qemu-trunk/target-sparc/op_helper.c
===================================================================
--- qemu-trunk.orig/target-sparc/op_helper.c
+++ qemu-trunk/target-sparc/op_helper.c
@@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            val = bswap16(val);
             break;
         case 4:
-            addr = bswap32(addr);
+            val = bswap32(val);
             break;
         case 8:
-            addr = bswap64(addr);
+            val = bswap64(val);
             break;
         default:
             break;
@@ -2375,13 +2375,13 @@ void helper_st_asi(target_ulong addr, ta
     case 0x89: // Secondary LE
         switch(size) {
         case 2:
-            addr = bswap16(addr);
+            val = bswap16(val);
             break;
         case 4:
-            addr = bswap32(addr);
+            val = bswap32(val);
             break;
         case 8:
-            addr = bswap64(addr);
+            val = bswap64(val);
             break;
         default:
             break;

Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Blue Swirl]

On 7/11/09, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady<sdbrady@ntlworld.com> wrote:
>  > On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
>  >> It is clear that intention is to byte-swap value to be written, not
>  >> the target address.
>  >
>  > @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
>  >     case 0x89: // Secondary LE
>  >         switch(size) {
>  >         case 2:
>  > -            addr = bswap16(addr);
>  > +            addr = bswap16(val);
>  >             ^^^^
>  > Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
>  > 64-bit cases)?  Also needs a 'signed-off-by:'...
>  >
>  > Cheers,
>  > --
>  > Stuart Brady
>  >
>
>
> Thanks, that part I did not runtime-tested.
>  Not sure if those asi stores are of any use for user-mode emulator.
>
>  Please find attached the corrected version.
>
>  Signed-off-by: igor.v.kovalenko@gmail.com

Thanks, I applied most of your patches.