From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPtsZ-0003R2-57
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 03:53:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPtsU-0003Jw-TO
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 03:53:46 -0400
Received: from [199.232.76.173] (port=40533 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPtsU-0003Jm-Q3
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 03:53:42 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:55799)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MPtsU-0001K5-Er
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 03:53:42 -0400
Received: by fxm7 with SMTP id 7so1398747fxm.34
	for <qemu-devel@nongnu.org>; Sun, 12 Jul 2009 00:53:41 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <b2fa41d60907111357k5fcd5780we5cf79cc6765c4b7@mail.gmail.com>
References: <b2fa41d60907111122p24d7e2a4vab24e15054205d6f@mail.gmail.com>
	<20090711204356.GA6219@miranda.arrow>
	<b2fa41d60907111357k5fcd5780we5cf79cc6765c4b7@mail.gmail.com>
Date: Sun, 12 Jul 2009 10:53:41 +0300
Message-ID: <f43fc5580907120053j1eb5a406q185445c8a103ef31@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian
	case typo
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org

On 7/11/09, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady<sdbrady@ntlworld.com> wrote:
>  > On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
>  >> It is clear that intention is to byte-swap value to be written, not
>  >> the target address.
>  >
>  > @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
>  >     case 0x89: // Secondary LE
>  >         switch(size) {
>  >         case 2:
>  > -            addr = bswap16(addr);
>  > +            addr = bswap16(val);
>  >             ^^^^
>  > Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
>  > 64-bit cases)?  Also needs a 'signed-off-by:'...
>  >
>  > Cheers,
>  > --
>  > Stuart Brady
>  >
>
>
> Thanks, that part I did not runtime-tested.
>  Not sure if those asi stores are of any use for user-mode emulator.
>
>  Please find attached the corrected version.
>
>  Signed-off-by: igor.v.kovalenko@gmail.com

Thanks, I applied most of your patches.