From: Blue Swirl <blauwirbel@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev
Date: Sun, 12 Jul 2009 21:29:17 +0300 [thread overview]
Message-ID: <f43fc5580907121129o4c67b694hc2ae9ff304b70da4@mail.gmail.com> (raw)
In-Reply-To: <200907121316.58408.paul@codesourcery.com>
On 7/12/09, Paul Brook <paul@codesourcery.com> wrote:
> > +static void ecc_register_devices(void)
> > +{
> > + sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1);
> > +}
>
> I suggest using a name that is a little less generic than "ecc". The device
> namespace is shared between all machines, and I'm pretty sure there are other
> ecc controllers out there. What does OpenFirmware call this device?
It's "eccmemctl". Actually this was one of the things I was going to
check before committing but forgot to. I'll rename it.
OpenFirmware names are not always consistent, for example escc (Zilog
device name) is escc on PPC, but it's zs (Zilog serial) on Sparc32.
Likewise ata (PPC) vs. ide on Sparc64. I think it'll still be useful
to aim for OF compatible names if possible.
prev parent reply other threads:[~2009-07-12 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com>
2009-07-12 12:16 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev Paul Brook
2009-07-12 18:29 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580907121129o4c67b694hc2ae9ff304b70da4@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).