From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MQ3nh-0005n4-C5
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 14:29:25 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MQ3nf-0005ko-Li
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 14:29:23 -0400
Received: from [199.232.76.173] (port=56149 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MQ3nf-0005kj-Hm
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 14:29:23 -0400
Received: from mx20.gnu.org ([199.232.41.8]:56177)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <blauwirbel@gmail.com>)
	id 1MQ3nf-0004fV-5y
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 14:29:23 -0400
Received: from fg-out-1718.google.com ([72.14.220.157])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MQ3ne-0006Ie-GQ
	for qemu-devel@nongnu.org; Sun, 12 Jul 2009 14:29:22 -0400
Received: by fg-out-1718.google.com with SMTP id l27so450208fgb.8
	for <qemu-devel@nongnu.org>; Sun, 12 Jul 2009 11:29:17 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <200907121316.58408.paul@codesourcery.com>
References: <200907120819.n6C8J4NJ017709@d01av04.pok.ibm.com>
	<200907121316.58408.paul@codesourcery.com>
Date: Sun, 12 Jul 2009 21:29:17 +0300
Message-ID: <f43fc5580907121129o4c67b694hc2ae9ff304b70da4@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert
	eccmemctl to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On 7/12/09, Paul Brook <paul@codesourcery.com> wrote:
> > +static void ecc_register_devices(void)
>  > +{
>  > +    sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1);
>  > +}
>
>  I suggest using a name that is a little less generic than "ecc". The device
>  namespace is shared between all machines, and I'm pretty sure there are other
>  ecc controllers out there. What does OpenFirmware call this device?

It's "eccmemctl". Actually this was one of the things I was going to
check before committing but forgot to. I'll rename it.

OpenFirmware names are not always consistent, for example escc (Zilog
device name) is escc on PPC, but it's zs (Zilog serial) on Sparc32.
Likewise ata (PPC) vs. ide on Sparc64. I think it'll still be useful
to aim for OF compatible names if possible.