From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MR5lY-0001O0-Dv
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 10:47:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MR5lW-0001Kv-Vx
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 10:47:27 -0400
Received: from [199.232.76.173] (port=48777 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MR5lW-0001Kr-O8
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 10:47:26 -0400
Received: from fg-out-1718.google.com ([72.14.220.156]:7521)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MR5lW-00087v-A5
	for qemu-devel@nongnu.org; Wed, 15 Jul 2009 10:47:26 -0400
Received: by fg-out-1718.google.com with SMTP id l27so1215173fgb.8
	for <qemu-devel@nongnu.org>; Wed, 15 Jul 2009 07:47:25 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m33a8y3osh.fsf@neno.mitica>
References: <f43fc5580907131232m1f3e95d5h178b097cf6845930@mail.gmail.com>
	<m3k52c8evv.fsf@neno.mitica>
	<f43fc5580907141154q4206f8b9s408e475b3f94846a@mail.gmail.com>
	<m33a8y3osh.fsf@neno.mitica>
Date: Wed, 15 Jul 2009 17:47:25 +0300
Message-ID: <f43fc5580907150747v34e7a6f1l60677ac035de2003@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Sparc32/PPC: convert escc to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

On 7/15/09, Juan Quintela <quintela@redhat.com> wrote:
> Blue Swirl <blauwirbel@gmail.com> wrote:
>  > On 7/14/09, Juan Quintela <quintela@trasno.org> wrote:
>  >> Blue Swirl <blauwirbel@gmail.com> wrote:
>
>
> I didn't explain myself enough, I guess.
>
>
>  >>  > +    qdev_set_prop_int(dev, "frequency", clock);
>
>                                    ^^^^^^^^^
>  ....
>
> >>  > +    clock = qdev_get_prop_int(&dev->qdev, "clock", 0);
>
>                                                   ^^^^^
>
>  You are setting a property named "frequency" and read a property named
>  "clock" :)  I just asked to use the same property in both places.

I see, thanks. Maybe an attempt to use an undeclared property should
raise an abort().