From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MR7RX-0008IA-A9 for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:34:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MR7RW-0008Gb-An for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:34:54 -0400 Received: from [199.232.76.173] (port=58351 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MR7RW-0008GG-1i for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:34:54 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:5139) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MR7RV-0004aN-CK for qemu-devel@nongnu.org; Wed, 15 Jul 2009 12:34:53 -0400 Received: by fg-out-1718.google.com with SMTP id d23so1556659fga.8 for ; Wed, 15 Jul 2009 09:34:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3cdfa5bc0907150833w4bf27bfj283242a7e0b5eb9a@mail.gmail.com> References: <3cdfa5bc0907150833w4bf27bfj283242a7e0b5eb9a@mail.gmail.com> Date: Wed, 15 Jul 2009 19:34:51 +0300 Message-ID: Subject: Re: [Qemu-devel] Misbehavior of qemu ppc tcg/translation? From: Blue Swirl Content-Type: multipart/mixed; boundary=000e0cd298165db2be046ec1228a List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Baojun Wang Cc: qemu-devel@nongnu.org --000e0cd298165db2be046ec1228a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/15/09, Baojun Wang wrote: > hi, list: > > I hope the following example is self-explained, in the assembler > code, we can use instruction like (instruction-as-data?): > > 100000b4: 10 00 12 34 .long 0x10001234 > > but the ppc translator set the exception flag and raise a PROGRAM > exception later, however on real machine, if the above instruction is > never ran, then everything should be OK. Thus the ppc translator raise > the exception too early? (I think it should only raise the PROGRAM > exception until tcg really trying to exec the instruction, but not on > translation time) Would the attached patch fix the problem? --000e0cd298165db2be046ec1228a Content-Type: application/x-patch; name="0001-PPC-stop-code-generation-when-we-reach-a-branch.patch" Content-Disposition: attachment; filename="0001-PPC-stop-code-generation-when-we-reach-a-branch.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fx69v2f4 RnJvbSA4YjNjOTQ3ZmYwYThkMjg4YzRlZjk5YjlkNGM0OWZmZGEyZjE2ZDNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCbHVlIFN3aXJsIDxibGF1d2lyYmVsQGdtYWlsLmNvbT4KRGF0 ZTogV2VkLCAxNSBKdWwgMjAwOSAxNjozMjo1MCArMDAwMApTdWJqZWN0OiBbUEFUQ0hdIFBQQzog c3RvcCBjb2RlIGdlbmVyYXRpb24gd2hlbiB3ZSByZWFjaCBhIGJyYW5jaAoKU2lnbmVkLW9mZi1i eTogQmx1ZSBTd2lybCA8YmxhdXdpcmJlbEBnbWFpbC5jb20+Ci0tLQogdGFyZ2V0LXBwYy90cmFu c2xhdGUuYyB8ICAgIDMgKystCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90YXJnZXQtcHBjL3RyYW5zbGF0ZS5jIGIvdGFyZ2V0 LXBwYy90cmFuc2xhdGUuYwppbmRleCA4ZmJjZjc2Li5lNjVjYjQ1IDEwMDY0NAotLS0gYS90YXJn ZXQtcHBjL3RyYW5zbGF0ZS5jCisrKyBiL3RhcmdldC1wcGMvdHJhbnNsYXRlLmMKQEAgLTkwNDIs NyArOTA0Miw4IEBAIHN0YXRpYyBhbHdheXNfaW5saW5lIHZvaWQgZ2VuX2ludGVybWVkaWF0ZV9j b2RlX2ludGVybmFsIChDUFVTdGF0ZSAqZW52LAogICAgICAgICAgICAgICAgICAgICAgY3R4LmV4 Y2VwdGlvbiAhPSBQT1dFUlBDX0VYQ1BfVFJBUCAmJgogICAgICAgICAgICAgICAgICAgICAgY3R4 LmV4Y2VwdGlvbiAhPSBQT1dFUlBDX0VYQ1BfQlJBTkNIKSkgewogICAgICAgICAgICAgZ2VuX2V4 Y2VwdGlvbihjdHhwLCBQT1dFUlBDX0VYQ1BfVFJBQ0UpOwotICAgICAgICB9IGVsc2UgaWYgKHVu bGlrZWx5KCgoY3R4Lm5pcCAmIChUQVJHRVRfUEFHRV9TSVpFIC0gMSkpID09IDApIHx8CisgICAg ICAgIH0gZWxzZSBpZiAodW5saWtlbHkoY3R4LmV4Y2VwdGlvbiA9PSBQT1dFUlBDX0VYQ1BfQlJB TkNIIHx8CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChjdHgubmlwICYgKFRBUkdFVF9Q QUdFX1NJWkUgLSAxKSkgPT0gMCkgfHwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZW52 LT5zaW5nbGVzdGVwX2VuYWJsZWQpIHx8CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2lu Z2xlc3RlcCB8fAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG51bV9pbnNucyA+PSBtYXhf aW5zbnMpKSB7Ci0tIAoxLjUuNi41Cgo= --000e0cd298165db2be046ec1228a--