Re: [Qemu-devel] [PATCH 01/14] GPIO rotary encoder implementation

[Blue Swirl <blauwirbel@gmail.com>]

On Sat, Jul 18, 2009 at 11:52 AM, Filip Navara<filip.navara@gmail.com> wrote:
> On Wed, Jul 15, 2009 at 5:38 PM, Filip Navara<filip.navara@gmail.com> wrote:
>> On Wed, Jul 15, 2009 at 5:33 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>> On Wed, 15 Jul 09 16:52:12 Central Europe Standard Time, Filip Navara
>>> <filip.navara@gmail.com> wrote:
>>>> This patch introduces an emulation of the rotary encoder that could be connected
>>>>  to GPIO controller.
>>>
>>> How about reset handling (qemu_register_reset)?
>>>
>>
>> Good point, it was on my TODO list, but I never implemented it. All
>> the devices currently lack it. I'll include it in next version.
>
> On second thought the GPIO devices don't need reset handling. In real
> hardware the rotary encoder is not affected by reset, so why would it
> be affected in QEMU? Unfortunately to get that working correctly the
> late_init callbacks, proposed in the devtree patches, are needed.

There is still internal state (for example s->extension) that may need reset.