From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MS5mO-0000rY-Q8
	for qemu-devel@nongnu.org; Sat, 18 Jul 2009 05:00:28 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MS5mJ-0000qp-5j
	for qemu-devel@nongnu.org; Sat, 18 Jul 2009 05:00:27 -0400
Received: from [199.232.76.173] (port=57920 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MS5mJ-0000qm-0k
	for qemu-devel@nongnu.org; Sat, 18 Jul 2009 05:00:23 -0400
Received: from mx20.gnu.org ([199.232.41.8]:12373)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <blauwirbel@gmail.com>)
	id 1MS5mI-0003hD-I4
	for qemu-devel@nongnu.org; Sat, 18 Jul 2009 05:00:22 -0400
Received: from mail-fx0-f224.google.com ([209.85.220.224])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MS5mH-0003Mn-LH
	for qemu-devel@nongnu.org; Sat, 18 Jul 2009 05:00:21 -0400
Received: by fxm24 with SMTP id 24so193458fxm.34
	for <qemu-devel@nongnu.org>; Sat, 18 Jul 2009 02:00:20 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <5b31733c0907180152x31e6a6c4g2b15b6ad2b9d3007@mail.gmail.com>
References: <E1MR5qB-0006E8-M8@lists.gnu.org>
	<f43fc5580907150833n1fb233a9v15c6a4cc55deb8d4@mail.gmail.com>
	<5b31733c0907150838j5a86dd7axa577676635644756@mail.gmail.com>
	<5b31733c0907180152x31e6a6c4g2b15b6ad2b9d3007@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 18 Jul 2009 12:00:00 +0300
Message-ID: <f43fc5580907180200w51098b77q7079a43f07024cbd@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 01/14] GPIO rotary encoder implementation
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

On Sat, Jul 18, 2009 at 11:52 AM, Filip Navara<filip.navara@gmail.com> wrot=
e:
> On Wed, Jul 15, 2009 at 5:38 PM, Filip Navara<filip.navara@gmail.com> wro=
te:
>> On Wed, Jul 15, 2009 at 5:33 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>>> On Wed, 15 Jul 09 16:52:12 Central Europe Standard Time, Filip Navara
>>> <filip.navara@gmail.com> wrote:
>>>> This patch introduces an emulation of the rotary encoder that could be=
 connected
>>>> =C2=A0to GPIO controller.
>>>
>>> How about reset handling (qemu_register_reset)?
>>>
>>
>> Good point, it was on my TODO list, but I never implemented it. All
>> the devices currently lack it. I'll include it in next version.
>
> On second thought the GPIO devices don't need reset handling. In real
> hardware the rotary encoder is not affected by reset, so why would it
> be affected in QEMU? Unfortunately to get that working correctly the
> late_init callbacks, proposed in the devtree patches, are needed.

There is still internal state (for example s->extension) that may need rese=
t.