From: Blue Swirl <blauwirbel@gmail.com>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sparc64 replace tsptr with helper routine
Date: Mon, 20 Jul 2009 09:49:36 +0300 [thread overview]
Message-ID: <f43fc5580907192349s6d684ae7s34f527f95196087e@mail.gmail.com> (raw)
In-Reply-To: <b2fa41d60907191419p536c6b84ve2ca27f030b74dee@mail.gmail.com>
On Mon, Jul 20, 2009 at 12:19 AM, Igor
Kovalenko<igor.v.kovalenko@gmail.com> wrote:
> tl and tsptr of members sparc64 cpu state must be changed
> simultaneously to keep trap state window in sync with current
> trap level. Currently translation of store to tl does not change
> tsptr, which leads to corrupt trap state on corresponding
> trap level.
>
> This patch removes tsptr from sparc64 cpu state and replaces
> all uses with call to helper routine.
I'd rather have the stores to TL fixed instead of introducing a
helper. A new function to set both TL and tsptr may help. Which stores
to TL do not change tsptr?
On CPU reset, TL should be MAXTL for POR and MIN(TL+1, MAXTL) in other
cases but your patch would set it to 0.
next prev parent reply other threads:[~2009-07-20 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 21:19 [Qemu-devel] [PATCH] sparc64 replace tsptr with helper routine Igor Kovalenko
2009-07-20 6:49 ` Blue Swirl [this message]
2009-07-20 19:00 ` Igor Kovalenko
2009-07-21 7:21 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580907192349s6d684ae7s34f527f95196087e@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=igor.v.kovalenko@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).