From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MTA2X-0008PK-0T
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:45:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MTA2V-0008P8-3m
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:45:31 -0400
Received: from [199.232.76.173] (port=49980 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MTA2U-0008P5-UQ
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:45:30 -0400
Received: from mx20.gnu.org ([199.232.41.8]:61256)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <blauwirbel@gmail.com>)
	id 1MTA2U-00012r-E1
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:45:30 -0400
Received: from fg-out-1718.google.com ([72.14.220.159])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MTA2T-0002G5-Jp
	for qemu-devel@nongnu.org; Tue, 21 Jul 2009 03:45:29 -0400
Received: by fg-out-1718.google.com with SMTP id l27so1040225fgb.8
	for <qemu-devel@nongnu.org>; Tue, 21 Jul 2009 00:45:28 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <b2fa41d60907201419k121d5c2fr274db4fbec2cc01c@mail.gmail.com>
References: <f43fc5580907200326r793e4f9am2db06ce0bd7dce1b@mail.gmail.com>
	<b2fa41d60907201419k121d5c2fr274db4fbec2cc01c@mail.gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Tue, 21 Jul 2009 10:45:08 +0300
Message-ID: <f43fc5580907210045pcefff74s5d3ab770b920dd95@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH, RFC] Sparc64: convert APB to qdev
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, qemu-devel <qemu-devel@nongnu.org>

On Tue, Jul 21, 2009 at 12:19 AM, Igor
Kovalenko<igor.v.kovalenko@gmail.com> wrote:
> On Mon, Jul 20, 2009 at 2:26 PM, Blue Swirl<blauwirbel@gmail.com> wrote:
>> I have a problem with APB conversion to qdev. For some reason, with
>> the patch applied, PCI config register access changes and OpenBIOS
>> can't find any PCI devices.
>
> You are using pci_host_data_* which expects opaque pointer to PCIHostState,
> so you need to pass appropriate opaque to cpu_register_io_memory.
> With this small amendment I verified there are no changes to qemu.log and
> serial console output.

Great, thanks!

> Not sure if this requires sign-off :)

Good question, perhaps the SoB experts should clarify the policy.

But in this case it makes no sense to commit my broken version and
then your patch. I think I'll just give you credit in the message for
the fixed commit.