From: Blue Swirl <blauwirbel@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary
Date: Sat, 25 Jul 2009 20:15:23 +0300 [thread overview]
Message-ID: <f43fc5580907251015v8dbd5f1qf4e63b0aad4ee222@mail.gmail.com> (raw)
In-Reply-To: <1248477406-50728-4-git-send-email-agraf@suse.de>
On Sat, Jul 25, 2009 at 2:16 AM, Alexander Graf<agraf@suse.de> wrote:
> When giving KVM a slot of a size not on page boundary, it chokes. So let's
> just round up the VGA BIOS size so nobody complains anymore and we don't need
> to implement sub-page slots.
> +
> + /* Round to page boundary */
> + vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK;
> +
> + /* Round to page boundary */
> + vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) & TARGET_PAGE_MASK;
This wrongly increases the size by extra TARGET_PAGE_SIZE, when
vga_bios_size mod TARGET_PAGE_SIZE == 0. Please use (vga_bios_size +
TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK.
next prev parent reply other threads:[~2009-07-25 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 23:16 [Qemu-devel] [PATCH 0/4] PPC KVM bringup patches round 2 v2 Alexander Graf
2009-07-24 23:16 ` [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON Alexander Graf
2009-07-24 23:16 ` [Qemu-devel] [PATCH 2/4] Use 64bit pointer for dirty log Alexander Graf
2009-07-24 23:16 ` [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary Alexander Graf
2009-07-24 23:16 ` [Qemu-devel] [PATCH 4/4] Give the kernel more room Alexander Graf
2009-07-25 17:15 ` Blue Swirl [this message]
2009-07-25 18:12 ` [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary Alexander Graf
2009-07-27 7:22 ` Blue Swirl
2009-07-27 13:51 ` [Qemu-devel] [PATCH 1/4] Move mp_state to CPU_COMMON Anthony Liguori
2009-07-27 13:56 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580907251015v8dbd5f1qf4e63b0aad4ee222@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).