From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MUkqX-0006iv-Uh
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 13:15:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MUkqX-0006i3-8z
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 13:15:45 -0400
Received: from [199.232.76.173] (port=55413 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MUkqX-0006hw-4K
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 13:15:45 -0400
Received: from fg-out-1718.google.com ([72.14.220.152]:13488)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MUkqW-0006hZ-Ku
	for qemu-devel@nongnu.org; Sat, 25 Jul 2009 13:15:44 -0400
Received: by fg-out-1718.google.com with SMTP id l27so420340fgb.8
	for <qemu-devel@nongnu.org>; Sat, 25 Jul 2009 10:15:43 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1248477406-50728-4-git-send-email-agraf@suse.de>
References: <1248477406-50728-1-git-send-email-agraf@suse.de>
	<1248477406-50728-2-git-send-email-agraf@suse.de>
	<1248477406-50728-3-git-send-email-agraf@suse.de>
	<1248477406-50728-4-git-send-email-agraf@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 25 Jul 2009 20:15:23 +0300
Message-ID: <f43fc5580907251015v8dbd5f1qf4e63b0aad4ee222@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page
	boundary
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

On Sat, Jul 25, 2009 at 2:16 AM, Alexander Graf<agraf@suse.de> wrote:
> When giving KVM a slot of a size not on page boundary, it chokes. So let'=
s
> just round up the VGA BIOS size so nobody complains anymore and we don't =
need
> to implement sub-page slots.

> +
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Round to page boundary */
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0vga_bios_size =3D (vga_bios_size + TARGET_PA=
GE_SIZE) & TARGET_PAGE_MASK;

> +
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Round to page boundary */
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0vga_bios_size =3D (vga_bios_size + TARGET_PA=
GE_SIZE) & TARGET_PAGE_MASK;

This wrongly increases the size by extra TARGET_PAGE_SIZE, when
vga_bios_size mod TARGET_PAGE_SIZE =3D=3D 0. Please use (vga_bios_size +
TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK.