From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MVKYJ-0006Uy-Ch
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:23:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MVKYD-0006Um-RV
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:23:17 -0400
Received: from [199.232.76.173] (port=47787 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MVKYD-0006Uj-MF
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:23:13 -0400
Received: from mx20.gnu.org ([199.232.41.8]:11382)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <blauwirbel@gmail.com>)
	id 1MVKYD-0001Uh-CP
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:23:13 -0400
Received: from mail-fx0-f224.google.com ([209.85.220.224])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1MVKYC-0005eo-2y
	for qemu-devel@nongnu.org; Mon, 27 Jul 2009 03:23:12 -0400
Received: by fxm24 with SMTP id 24so2356404fxm.34
	for <qemu-devel@nongnu.org>; Mon, 27 Jul 2009 00:23:11 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <D7860B70-242E-43EA-B6D5-648109D3A2C8@suse.de>
References: <1248477406-50728-1-git-send-email-agraf@suse.de>
	<1248477406-50728-2-git-send-email-agraf@suse.de>
	<1248477406-50728-3-git-send-email-agraf@suse.de>
	<1248477406-50728-4-git-send-email-agraf@suse.de>
	<f43fc5580907251015v8dbd5f1qf4e63b0aad4ee222@mail.gmail.com>
	<D7860B70-242E-43EA-B6D5-648109D3A2C8@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 27 Jul 2009 10:22:51 +0300
Message-ID: <f43fc5580907270022l118e835bt1525294c8f26c6df@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page
	boundary
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

On Sat, Jul 25, 2009 at 9:12 PM, Alexander Graf<agraf@suse.de> wrote:
>
> On 25.07.2009, at 19:15, Blue Swirl wrote:
>
>> On Sat, Jul 25, 2009 at 2:16 AM, Alexander Graf<agraf@suse.de> wrote:
>>>
>>> When giving KVM a slot of a size not on page boundary, it chokes. So
>>> let's
>>> just round up the VGA BIOS size so nobody complains anymore and we don'=
t
>>> need
>>> to implement sub-page slots.
>>
>>> +
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Round to page boundary */
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0vga_bios_size =3D (vga_bios_size + TARGET_=
PAGE_SIZE) &
>>> TARGET_PAGE_MASK;
>>
>>> +
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0/* Round to page boundary */
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0vga_bios_size =3D (vga_bios_size + TARGET_=
PAGE_SIZE) &
>>> TARGET_PAGE_MASK;
>>
>> This wrongly increases the size by extra TARGET_PAGE_SIZE, when
>> vga_bios_size mod TARGET_PAGE_SIZE =3D=3D 0. Please use (vga_bios_size +
>> TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK.
>
> Right, that's what Jan said too. Mind to change it when applying the patc=
h
> or would you prefer me to do a respin?

I changed it and applied, also applied 4/4.