From: Blue Swirl <blauwirbel@gmail.com>
To: Artyom Tarasenko <atar4qemu@googlemail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Patch] sparc32 remove an unnecessary cpu irq set
Date: Thu, 13 Aug 2009 22:33:22 +0300 [thread overview]
Message-ID: <f43fc5580908131233n66afaaa9l12c5380076762750@mail.gmail.com> (raw)
In-Reply-To: <fb8d4f70908130844i63f7795ekdef16cdbbf1c3954@mail.gmail.com>
On Thu, Aug 13, 2009 at 6:44 PM, Artyom
Tarasenko<atar4qemu@googlemail.com> wrote:
> 2009/8/12 Igor Kovalenko <igor.v.kovalenko@gmail.com>:
>> PUT_PSR is asking to be made inline function with arch-specific parts,
>> the sparc64 counterpart is too similar.
> Ok, here we go:
Sorry, it does not apply.
> -#if !defined(CONFIG_USER_ONLY)
> - cpu_check_irqs(env);
> -#endif
This should be in a separate patch, preferably one with the check
moved to helper_wrpsr.
> +/* sum4m.c, sun4u.c */
> +void cpu_check_irqs(CPUSPARCState *env);
The prototypes should remain in header files.
next prev parent reply other threads:[~2009-08-13 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 16:28 [Qemu-devel] [Patch] sparc32 remove an unnecessary cpu irq set Artyom Tarasenko
[not found] ` <b2fa41d60908121143tb46ceeehfa37bbc448e0eb5a@mail.gmail.com>
2009-08-13 15:44 ` Artyom Tarasenko
2009-08-13 19:33 ` Blue Swirl [this message]
2009-08-14 10:37 ` Artyom Tarasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580908131233n66afaaa9l12c5380076762750@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=atar4qemu@googlemail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).