From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mbg3X-0001bl-22 for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:33:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mbg3V-0001bZ-GP for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:33:46 -0400 Received: from [199.232.76.173] (port=48397 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mbg3V-0001bW-CD for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:33:45 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:19551) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mbg3U-0004JN-My for qemu-devel@nongnu.org; Thu, 13 Aug 2009 15:33:44 -0400 Received: by fg-out-1718.google.com with SMTP id d23so265653fga.8 for ; Thu, 13 Aug 2009 12:33:43 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Blue Swirl Date: Thu, 13 Aug 2009 22:33:22 +0300 Message-ID: Subject: Re: [Qemu-devel] [Patch] sparc32 remove an unnecessary cpu irq set Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko Cc: qemu-devel On Thu, Aug 13, 2009 at 6:44 PM, Artyom Tarasenko wrote: > 2009/8/12 Igor Kovalenko : >> PUT_PSR is asking to be made inline function with arch-specific parts, >> the sparc64 counterpart is too similar. > Ok, here we go: Sorry, it does not apply. > -#if !defined(CONFIG_USER_ONLY) > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0cpu_check_irqs(env); > -#endif This should be in a separate patch, preferably one with the check moved to helper_wrpsr. > +/* sum4m.c, sun4u.c */ > +void cpu_check_irqs(CPUSPARCState *env); The prototypes should remain in header files.