From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiWUv-0003Z5-Uk for qemu-devel@nongnu.org; Tue, 01 Sep 2009 12:46:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiWUr-0003YC-Cr for qemu-devel@nongnu.org; Tue, 01 Sep 2009 12:46:21 -0400 Received: from [199.232.76.173] (port=34460 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiWUr-0003Y9-6x for qemu-devel@nongnu.org; Tue, 01 Sep 2009 12:46:17 -0400 Received: from mail-ew0-f223.google.com ([209.85.219.223]:45305) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiWUq-0007jB-OC for qemu-devel@nongnu.org; Tue, 01 Sep 2009 12:46:16 -0400 Received: by ewy23 with SMTP id 23so125544ewy.8 for ; Tue, 01 Sep 2009 09:46:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1251791775-5358-1-git-send-email-kraxel@redhat.com> <1251791775-5358-2-git-send-email-kraxel@redhat.com> From: Blue Swirl Date: Tue, 1 Sep 2009 19:45:53 +0300 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 1/4] qdev: integrate reset List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Gerd Hoffmann , qemu-devel@nongnu.org On Tue, Sep 1, 2009 at 7:36 PM, Juan Quintela wrote: > Blue Swirl wrote: >> On Tue, Sep 1, 2009 at 10:56 AM, Gerd Hoffmann wrote: >> >>> @@ -110,6 +110,9 @@ struct DeviceInfo { >>> =C2=A0 =C2=A0 Property *props; >>> =C2=A0 =C2=A0 int no_user; >>> >>> + =C2=A0 =C2=A0/* callbacks */ >>> + =C2=A0 =C2=A0QEMUResetHandler *reset; >>> + >> >> This would remove the need for registration but I had in my mind a bit >> more complex solution like VMState structures. Even better, VMState >> could be enhanced so that the reset value of the fields could be >> specified (when not zero). > > That soonds nice, but ... not every field in the structures are used > during migration. =C2=A0Do we want to merge both things? New flags that tell whether a VMState field is used for savevm or reset?